PDA

View Full Version : [Mondrian] Aggregation.flush code review



Richard Emberson
04-04-2007, 04:10 PM
It would seem that in the Aggregation
flush(CacheControl,RolapCacheRegion) method, if
boolean bitmapsIntersect is false, then
there is no need to segmentLoop for loop since

if (!bitmapsIntersect) {
continue;
}

always executes.

Yes?


Richard


--
Quis custodiet ipsos custodes:
This email message is for the sole use of the intended recipient(s) and
may contain confidential information. Any unauthorized review, use,
disclosure or distribution is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies of the original message.
_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Richard Emberson
04-04-2007, 04:40 PM
Added "enter the"

Richard Emberson wrote:
>
> It would seem that in the Aggregation
> flush(CacheControl,RolapCacheRegion) method, if
> boolean bitmapsIntersect is false, then
> there is no need to enter the segmentLoop for loop since
>
> if (!bitmapsIntersect) {
> continue;
> }
>
> always executes.
>
> Yes?
>
>
> Richard
>
>
> --
> Quis custodiet ipsos custodes:
> This email message is for the sole use of the intended recipient(s) and
> may contain confidential information. Any unauthorized review, use,
> disclosure or distribution is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all
> copies of the original message.
> _______________________________________________
> Mondrian mailing list
> Mondrian (AT) pentaho (DOT) org
> http://lists.pentaho.org/mailman/listinfo/mondrian
>


--
Quis custodiet ipsos custodes:
This email message is for the sole use of the intended recipient(s) and
may contain confidential information. Any unauthorized review, use,
disclosure or distribution is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies of the original message.
_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Julian Hyde
04-05-2007, 03:20 AM
Yes. You could either short-circuit the loop or not bother computing
bitmapsIntersect. The latter is simpler, so gets my vote.

> -----Original Message-----
> From: mondrian-bounces (AT) pentaho (DOT) org
> [mailto:mondrian-bounces (AT) pentaho (DOT) org] On Behalf Of Richard Emberson
> Sent: Wednesday, April 04, 2007 1:41 PM
> To: Mondrian developer mailing list
> Subject: Re: [Mondrian] Aggregation.flush code review
>
> Added "enter the"
>
> Richard Emberson wrote:
> >
> > It would seem that in the Aggregation
> > flush(CacheControl,RolapCacheRegion) method, if
> > boolean bitmapsIntersect is false, then
> > there is no need to enter the segmentLoop for loop since
> >
> > if (!bitmapsIntersect) {
> > continue;
> > }
> >
> > always executes.
> >
> > Yes?
> >
> >
> > Richard
> >
> >
> > --
> > Quis custodiet ipsos custodes:
> > This email message is for the sole use of the intended
> recipient(s) and
> > may contain confidential information. Any unauthorized review, use,
> > disclosure or distribution is prohibited. If you are not
> the intended
> > recipient, please contact the sender by reply email and destroy all
> > copies of the original message.
> > _______________________________________________
> > Mondrian mailing list
> > Mondrian (AT) pentaho (DOT) org
> > http://lists.pentaho.org/mailman/listinfo/mondrian
> >
>
>
> --
> Quis custodiet ipsos custodes:
> This email message is for the sole use of the intended
> recipient(s) and
> may contain confidential information. Any unauthorized review, use,
> disclosure or distribution is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all
> copies of the original message.
> _______________________________________________
> Mondrian mailing list
> Mondrian (AT) pentaho (DOT) org
> http://lists.pentaho.org/mailman/listinfo/mondrian
>

_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian