PDA

View Full Version : [Mondrian] RolapSchema caching Sql.Dialect



Richard Emberson
04-17-2007, 11:40 AM
Currently, each RolapStar and each RolapHierarchy call to
its convertInlineTableToRelation calls the
RolapSchema getDialect() method which re-creates a
SqlQuery.Dialect object.
Should we let each RolapSchema instance cache the first
SqlQuery.Dialect object after its created?

Richard

--
Quis custodiet ipsos custodes:
This email message is for the sole use of the intended recipient(s) and
may contain confidential information. Any unauthorized review, use,
disclosure or distribution is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies of the original message.
_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Julian Hyde
04-18-2007, 04:00 AM
I don't see a performance problem, so I would do whatever takes the
fewest lines of code. (Which is probably what we have today.)

Note that there is a proposal on the table - from Michael B. - to
introduce a 'context' which ties together all of the SQL queries
executed to satisfy a given MDX query. That might be a more suitable
home for a cached Dialect.

Julian

> -----Original Message-----
> From: mondrian-bounces (AT) pentaho (DOT) org
> [mailto:mondrian-bounces (AT) pentaho (DOT) org] On Behalf Of Richard Emberson
> Sent: Tuesday, April 17, 2007 8:36 AM
> To: Mondrian developer mailing list
> Subject: [Mondrian] RolapSchema caching Sql.Dialect
>
>
> Currently, each RolapStar and each RolapHierarchy call to
> its convertInlineTableToRelation calls the
> RolapSchema getDialect() method which re-creates a
> SqlQuery.Dialect object.
> Should we let each RolapSchema instance cache the first
> SqlQuery.Dialect object after its created?
>
> Richard
>
> --
> Quis custodiet ipsos custodes:
> This email message is for the sole use of the intended
> recipient(s) and
> may contain confidential information. Any unauthorized review, use,
> disclosure or distribution is prohibited. If you are not the intended
> recipient, please contact the sender by reply email and destroy all
> copies of the original message.
> _______________________________________________
> Mondrian mailing list
> Mondrian (AT) pentaho (DOT) org
> http://lists.pentaho.org/mailman/listinfo/mondrian
>

_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Richard Emberson
04-18-2007, 09:00 AM
I read the comment in RolapSchema associated with the
getDialect() method:

NOTE: This method is not cheap. The implementation gets a connection
from the connection pool.

and assumed there was an issue. Should the comment be removed?

Richard

Julian Hyde wrote:
> I don't see a performance problem, so I would do whatever takes the
> fewest lines of code. (Which is probably what we have today.)
>
> Note that there is a proposal on the table - from Michael B. - to
> introduce a 'context' which ties together all of the SQL queries
> executed to satisfy a given MDX query. That might be a more suitable
> home for a cached Dialect.
>
> Julian
>
>> -----Original Message-----
>> From: mondrian-bounces (AT) pentaho (DOT) org
>> [mailto:mondrian-bounces (AT) pentaho (DOT) org] On Behalf Of Richard Emberson
>> Sent: Tuesday, April 17, 2007 8:36 AM
>> To: Mondrian developer mailing list
>> Subject: [Mondrian] RolapSchema caching Sql.Dialect
>>
>>
>> Currently, each RolapStar and each RolapHierarchy call to
>> its convertInlineTableToRelation calls the
>> RolapSchema getDialect() method which re-creates a
>> SqlQuery.Dialect object.
>> Should we let each RolapSchema instance cache the first
>> SqlQuery.Dialect object after its created?
>>
>> Richard
>>
>> --
>> Quis custodiet ipsos custodes:
>> This email message is for the sole use of the intended
>> recipient(s) and
>> may contain confidential information. Any unauthorized review, use,
>> disclosure or distribution is prohibited. If you are not the intended
>> recipient, please contact the sender by reply email and destroy all
>> copies of the original message.
>> _______________________________________________
>> Mondrian mailing list
>> Mondrian (AT) pentaho (DOT) org
>> http://lists.pentaho.org/mailman/listinfo/mondrian
>>
>
> _______________________________________________
> Mondrian mailing list
> Mondrian (AT) pentaho (DOT) org
> http://lists.pentaho.org/mailman/listinfo/mondrian
>


--
Quis custodiet ipsos custodes:
This email message is for the sole use of the intended recipient(s) and
may contain confidential information. Any unauthorized review, use,
disclosure or distribution is prohibited. If you are not the intended
recipient, please contact the sender by reply email and destroy all
copies of the original message.
_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian