PDA

View Full Version : [Mondrian] FW: DialectTest [Eigenbase perforce change 9288 forreview]



Julian Hyde
05-19-2007, 06:27 PM
I just added a unit test for the SqlQuery.Dialect class. The goal is to
make sure that Dialect is not under-stating any database's
capabilitities - so if a database cannot do something (say sort by
aliases defined in the select clause) then the test will require that
the database gives an error. This will help us detect when new versions
of databases fix old versions' failings, and thus fully exploit each
database.

I have run the test on Access, Oracle, MySQL and Derby. Can I have
volunteers to run the test on other databases; especially Postgres,
Microsoft SQL Server, DB2, Teradata, and LucidDB.

Julian

-----Original Message-----
From: Julian Hyde [mailto:jhyde (AT) users (DOT) sourceforge.net]
Sent: Saturday, May 19, 2007 2:50 PM
To: Andreas Voss; Bart Pappyn; Julian Hyde; John V. Sichi; Matt
Campbell; Sam Birney; Zelaine Fong
Subject: Eigenbase perforce change 9288 for review

http://p4web.eigenbase.org/@md=d&c=6PU@//9288?ac=10

Change 9288 by jhyde (AT) jhyde (DOT) marmalade2 on 2007/05/19 14:48:09

MONDRIAN: Add DialectTest.

Affected files ...

.... //open/mondrian/src/main/mondrian/rolap/sql/SqlQuery.java#78 edit
.... //open/mondrian/testsrc/main/mondrian/test/DialectTest.java#1 add
.... //open/mondrian/testsrc/main/mondrian/test/Main.java#68 edit
.... //open/mondrian/testsrc/main/mondrian/test/TestContext.java#41 edit


_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Sherman Wood
05-20-2007, 11:54 AM
Failure in Postgres 8.2.3.

[java] 1)
testAllowsFromQuery(mondrian.test.DialectTest)mondrian.olap.MondrianExcept
ion: Mondrian Error:Internal error: query [select * from (select * from
"sales_fact_1997")] failed
[java] at
mondrian.resource.MondrianResource$_Def0.ex(MondrianResource.java:755)
[java] at mondrian.olap.Util.newInternal(Util.java:1103)
[java] at
mondrian.test.DialectTest.assertQuerySucceeds(DialectTest.java:357)
[java] at
mondrian.test.DialectTest.testAllowsFromQuery(DialectTest.java:202)
[java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)

<snip>

[java] Caused by: org.postgresql.util.PSQLException: ERROR: subquery
in FROM must have an alias
[java] at
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecuto
rImpl.java:1548)


I notice that:

SqlQuery.requiresAliasForFromItems() {
return isPostgres();
}

is now never called.


Sherman


-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Julian Hyde
Sent: Saturday, May 19, 2007 3:13 PM
To: mondrian (AT) pentaho (DOT) org
Subject: [Mondrian] FW: DialectTest [Eigenbase perforce change 9288
forreview]

I just added a unit test for the SqlQuery.Dialect class. The goal is to
make sure that Dialect is not under-stating any database's
capabilitities - so if a database cannot do something (say sort by
aliases defined in the select clause) then the test will require that
the database gives an error. This will help us detect when new versions
of databases fix old versions' failings, and thus fully exploit each
database.

I have run the test on Access, Oracle, MySQL and Derby. Can I have
volunteers to run the test on other databases; especially Postgres,
Microsoft SQL Server, DB2, Teradata, and LucidDB.

Julian

-----Original Message-----
From: Julian Hyde [mailto:jhyde (AT) users (DOT) sourceforge.net]
Sent: Saturday, May 19, 2007 2:50 PM
To: Andreas Voss; Bart Pappyn; Julian Hyde; John V. Sichi; Matt
Campbell; Sam Birney; Zelaine Fong
Subject: Eigenbase perforce change 9288 for review

http://p4web.eigenbase.org/@md=d&c=6PU@//9288?ac=10

Change 9288 by jhyde (AT) jhyde (DOT) marmalade2 on 2007/05/19 14:48:09

MONDRIAN: Add DialectTest.

Affected files ...

.... //open/mondrian/src/main/mondrian/rolap/sql/SqlQuery.java#78 edit
.... //open/mondrian/testsrc/main/mondrian/test/DialectTest.java#1 add
.... //open/mondrian/testsrc/main/mondrian/test/Main.java#68 edit
.... //open/mondrian/testsrc/main/mondrian/test/TestContext.java#41 edit


_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Zelaine Fong
05-21-2007, 12:40 PM
Eigenchange 9291 has the fixes needed to make DialectTest run on LucidDb.

-- Zelaine


Julian Hyde wrote:
> I just added a unit test for the SqlQuery.Dialect class. The goal is to
> make sure that Dialect is not under-stating any database's
> capabilitities - so if a database cannot do something (say sort by
> aliases defined in the select clause) then the test will require that
> the database gives an error. This will help us detect when new versions
> of databases fix old versions' failings, and thus fully exploit each
> database.
>
> I have run the test on Access, Oracle, MySQL and Derby. Can I have
> volunteers to run the test on other databases; especially Postgres,
> Microsoft SQL Server, DB2, Teradata, and LucidDB.
>
> Julian
>
> -----Original Message-----
> From: Julian Hyde [mailto:jhyde (AT) users (DOT) sourceforge.net]
> Sent: Saturday, May 19, 2007 2:50 PM
> To: Andreas Voss; Bart Pappyn; Julian Hyde; John V. Sichi; Matt
> Campbell; Sam Birney; Zelaine Fong
> Subject: Eigenbase perforce change 9288 for review
>
> http://p4web.eigenbase.org/@md=d&c=6PU@//9288?ac=10
>
> Change 9288 by jhyde (AT) jhyde (DOT) marmalade2 on 2007/05/19 14:48:09
>
> MONDRIAN: Add DialectTest.
>
> Affected files ...
>
> ... //open/mondrian/src/main/mondrian/rolap/sql/SqlQuery.java#78 edit
> ... //open/mondrian/testsrc/main/mondrian/test/DialectTest.java#1 add
> ... //open/mondrian/testsrc/main/mondrian/test/Main.java#68 edit
> ... //open/mondrian/testsrc/main/mondrian/test/TestContext.java#41 edit
>
>
> _______________________________________________
> Mondrian mailing list
> Mondrian (AT) pentaho (DOT) org
> http://lists.pentaho.org/mailman/listinfo/mondrian
_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian