PDA

View Full Version : FW: [Mondrian] FW: DialectTest [Eigenbase perforce change9288forreview]



Julian Hyde
05-20-2007, 04:04 PM
Sherman,

Thanks for the postgres fixes. I have checked in as change 9290.

Richard,

Sherman's test log (attached) shows non-determinacy in CrossJoinTest
against Postgres. Can you take a look at that test please.

Julian


-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Sherman Wood
Sent: Sunday, May 20, 2007 8:47 AM
To: Mondrian developer mailing list
Subject: RE: [Mondrian] FW: DialectTest [Eigenbase perforce change
9288forreview]


Failure in Postgres 8.2.3.

[java] 1)
testAllowsFromQuery(mondrian.test.DialectTest)mondrian.olap.MondrianExce
pt
ion: Mondrian Error:Internal error: query [select * from (select * from
"sales_fact_1997")] failed
[java] at
mondrian.resource.MondrianResource$_Def0.ex(MondrianResource.java:755)
[java] at mondrian.olap.Util.newInternal(Util.java:1103)
[java] at
mondrian.test.DialectTest.assertQuerySucceeds(DialectTest.java:357)
[java] at
mondrian.test.DialectTest.testAllowsFromQuery(DialectTest.java:202)
[java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)

<snip>

[java] Caused by: org.postgresql.util.PSQLException: ERROR:
subquery
in FROM must have an alias
[java] at
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecu
to
rImpl.java:1548)


I notice that:

SqlQuery.requiresAliasForFromItems() {
return isPostgres();
}

is now never called.


Sherman


-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Julian Hyde
Sent: Saturday, May 19, 2007 3:13 PM
To: mondrian (AT) pentaho (DOT) org
Subject: [Mondrian] FW: DialectTest [Eigenbase perforce change 9288
forreview]

I just added a unit test for the SqlQuery.Dialect class. The goal is to
make sure that Dialect is not under-stating any database's
capabilitities - so if a database cannot do something (say sort by
aliases defined in the select clause) then the test will require that
the database gives an error. This will help us detect when new versions
of databases fix old versions' failings, and thus fully exploit each
database.

I have run the test on Access, Oracle, MySQL and Derby. Can I have
volunteers to run the test on other databases; especially Postgres,
Microsoft SQL Server, DB2, Teradata, and LucidDB.

Julian

-----Original Message-----
From: Julian Hyde [mailto:jhyde (AT) users (DOT) sourceforge.net]
Sent: Saturday, May 19, 2007 2:50 PM
To: Andreas Voss; Bart Pappyn; Julian Hyde; John V. Sichi; Matt
Campbell; Sam Birney; Zelaine Fong
Subject: Eigenbase perforce change 9288 for review

http://p4web.eigenbase.org/@md=d&c=6PU@//9288?ac=10

Change 9288 by jhyde (AT) jhyde (DOT) marmalade2 on 2007/05/19 14:48:09

MONDRIAN: Add DialectTest.

Affected files ...

.... //open/mondrian/src/main/mondrian/rolap/sql/SqlQuery.java#78 edit
.... //open/mondrian/testsrc/main/mondrian/test/DialectTest.java#1 add
.... //open/mondrian/testsrc/main/mondrian/test/Main.java#68 edit
.... //open/mondrian/testsrc/main/mondrian/test/TestContext.java#41 edit


_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

Sherman Wood
05-21-2007, 12:21 AM
That fixed it for Postgres.


Sherman

-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Julian Hyde
Sent: Sunday, May 20, 2007 1:00 PM
To: 'Sherman Wood'; 'Richard Emberson'
Cc: mondrian (AT) pentaho (DOT) org
Subject: FW: [Mondrian] FW: DialectTest [Eigenbase perforce
change9288forreview]

Sherman,

Thanks for the postgres fixes. I have checked in as change 9290.

Richard,

Sherman's test log (attached) shows non-determinacy in CrossJoinTest
against Postgres. Can you take a look at that test please.

Julian


-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Sherman Wood
Sent: Sunday, May 20, 2007 8:47 AM
To: Mondrian developer mailing list
Subject: RE: [Mondrian] FW: DialectTest [Eigenbase perforce change
9288forreview]


Failure in Postgres 8.2.3.

[java] 1)
testAllowsFromQuery(mondrian.test.DialectTest)mondrian.olap.MondrianExce
pt
ion: Mondrian Error:Internal error: query [select * from (select * from
"sales_fact_1997")] failed
[java] at
mondrian.resource.MondrianResource$_Def0.ex(MondrianResource.java:755)
[java] at mondrian.olap.Util.newInternal(Util.java:1103)
[java] at
mondrian.test.DialectTest.assertQuerySucceeds(DialectTest.java:357)
[java] at
mondrian.test.DialectTest.testAllowsFromQuery(DialectTest.java:202)
[java] at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)

<snip>

[java] Caused by: org.postgresql.util.PSQLException: ERROR:
subquery
in FROM must have an alias
[java] at
org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecu
to
rImpl.java:1548)


I notice that:

SqlQuery.requiresAliasForFromItems() {
return isPostgres();
}

is now never called.


Sherman


-----Original Message-----
From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org]
On Behalf Of Julian Hyde
Sent: Saturday, May 19, 2007 3:13 PM
To: mondrian (AT) pentaho (DOT) org
Subject: [Mondrian] FW: DialectTest [Eigenbase perforce change 9288
forreview]

I just added a unit test for the SqlQuery.Dialect class. The goal is to
make sure that Dialect is not under-stating any database's
capabilitities - so if a database cannot do something (say sort by
aliases defined in the select clause) then the test will require that
the database gives an error. This will help us detect when new versions
of databases fix old versions' failings, and thus fully exploit each
database.

I have run the test on Access, Oracle, MySQL and Derby. Can I have
volunteers to run the test on other databases; especially Postgres,
Microsoft SQL Server, DB2, Teradata, and LucidDB.

Julian

-----Original Message-----
From: Julian Hyde [mailto:jhyde (AT) users (DOT) sourceforge.net]
Sent: Saturday, May 19, 2007 2:50 PM
To: Andreas Voss; Bart Pappyn; Julian Hyde; John V. Sichi; Matt
Campbell; Sam Birney; Zelaine Fong
Subject: Eigenbase perforce change 9288 for review

http://p4web.eigenbase.org/@md=d&c=6PU@//9288?ac=10

Change 9288 by jhyde (AT) jhyde (DOT) marmalade2 on 2007/05/19 14:48:09

MONDRIAN: Add DialectTest.

Affected files ...

.... //open/mondrian/src/main/mondrian/rolap/sql/SqlQuery.java#78 edit
.... //open/mondrian/testsrc/main/mondrian/test/DialectTest.java#1 add
.... //open/mondrian/testsrc/main/mondrian/test/Main.java#68 edit
.... //open/mondrian/testsrc/main/mondrian/test/TestContext.java#41 edit


_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian

_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian