PDA

View Full Version : [Mondrian] Member comparison by reference



Anton Nikitin
05-30-2007, 07:40 AM
Julian,



may I suggest including in Mondrian development conventions the rule not to
use expressions like "member1 == member2" but use Util.equals(member1,
member2) instead.

The implementation of equals for OlapElementBase already includes reference
comparison as a first step so I don't expect any significant performance
drawback.



In the past we got some hardly reproducible errors because of it (with our
custom member readers, which were based on ones from mondrian.rolap).



Version 2.3.2 still includes such comparisons.



Anton


_______________________________________________
Mondrian mailing list
Mondrian (AT) pentaho (DOT) org
http://lists.pentaho.org/mailman/listinfo/mondrian