Hitachi Vantara Pentaho Community Forums
Results 1 to 2 of 2

Thread: re-factoring

  1. #1
    James Dixon Guest

    Default re-factoring

    Phase 1: Dependency removal
    I will remove dependencies between the engine classes and the UI
    classes. I will not re-factor any classes at this point so that any
    merging that needs to be done is easy. The build will not change, a
    single jar will be created.
    This is in progress.

    Phase 2: Re-factoring UI classes
    I will move all the UI classes to new packages. I won't make any
    other changes during this phase so it will be a quick operation and
    the only changes will be the package names and imports as necessary.
    I'll send out advanced notice before I do this as merging afterwards
    will be a pain.
    I propose that the new packages are all in org.pentaho.di.ui and that
    the rest of the package structure is kept:
    e.g.
    org.pentaho.di.cluster.dialog.ClusterSchemaDialog.java
    will move to
    org.pentaho.di.ui.cluster.dialog.ClusterSchemaDialog.java

    At that time the files that I am planning on re-factoring are:
    org.pentaho.di.cluster.dialog.*
    org.pentaho.di.core.database.dialog.*
    org.pentaho.di.core.database.wizard.*
    org.pentaho.di.core.dialog.*
    org.pentaho.di.core.PrintSpool
    org.pentaho.di.core.widget.*
    org.pentaho.di.i18n.editor.*
    org.pentaho.di.images.*
    org.pentaho.di.job.dialog.*
    org.pentaho.di.job.entries.*.*Dialog
    org.pentaho.di.partition.dialog.*
    org.pentaho.di.repository.dialog.*
    org.pentaho.di.spoon.*
    org.pentaho.di.trans.dialog.*
    org.pentaho.di.trans.step.BaseStepDialog
    org.pentaho.di.trans.step.StepErrorMetaDialog.java
    org.pentaho.di.trans.steps.*.*Dialog


    The build will not change, a single jar will be created.
    I'll probably do this this weekend.

    Phase 3: New source tree
    The org.pentaho.di.ui.* packages will be moved to a new source tree
    kettle/src-ui
    The build will change, two jars will be created - kettle.jar and
    kettle-ui.jar

    Let me know if anyone has concerns about this.

    James Dixon

    Chief Geek, Pentaho Corp
    Citadel International, Suite 340, 5950 Hazeltine National Dr. ,
    Orlando, FL 32822, USA
    +1 407 812-OPEN (6736), Fax: 407-517-4575
    Toll Free: 1-866-496-2703



    --~--~---------~--~----~------------~-------~--~----~
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
    To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
    -~----------~----~----~----~------~----~------~--~---

  2. #2
    James Dixon Guest

    Default Re: re-factoring

    The refactoring is now done. The build.xml now generates two jars,
    one for the engine and one for the UI. Everything seems fine on my
    box. I have not re-done the dummy plugins yet. Let me know if you
    come across any problems.

    James Dixon

    Chief Geek, Pentaho Corp
    Citadel International, Suite 340, 5950 Hazeltine National Dr. ,
    Orlando, FL 32822, USA
    +1 407 812-OPEN (6736), Fax: 407-517-4575
    Toll Free: 1-866-496-2703


    On Jul 11, 2007, at 12:46 AM, James Dixon wrote:

    >
    >
    > Phase 1: Dependency removal
    > I will remove dependencies between the engine classes and the UI
    > classes. I will not re-factor any classes at this point so that any
    > merging that needs to be done is easy. The build will not change, a
    > single jar will be created.
    > This is in progress.
    >
    > Phase 2: Re-factoring UI classes
    > I will move all the UI classes to new packages. I won't make any
    > other changes during this phase so it will be a quick operation and
    > the only changes will be the package names and imports as
    > necessary. I'll send out advanced notice before I do this as
    > merging afterwards will be a pain.
    > I propose that the new packages are all in org.pentaho.di.ui and
    > that the rest of the package structure is kept:
    > e.g.
    > org.pentaho.di.cluster.dialog.ClusterSchemaDialog.java
    > will move to
    > org.pentaho.di.ui.cluster.dialog.ClusterSchemaDialog.java
    >
    > At that time the files that I am planning on re-factoring are:
    > org.pentaho.di.cluster.dialog.*
    > org.pentaho.di.core.database.dialog.*
    > org.pentaho.di.core.database.wizard.*
    > org.pentaho.di.core.dialog.*
    > org.pentaho.di.core.PrintSpool
    > org.pentaho.di.core.widget.*
    > org.pentaho.di.i18n.editor.*
    > org.pentaho.di.images.*
    > org.pentaho.di.job.dialog.*
    > org.pentaho.di.job.entries.*.*Dialog
    > org.pentaho.di.partition.dialog.*
    > org.pentaho.di.repository.dialog.*
    > org.pentaho.di.spoon.*
    > org.pentaho.di.trans.dialog.*
    > org.pentaho.di.trans.step.BaseStepDialog
    > org.pentaho.di.trans.step.StepErrorMetaDialog.java
    > org.pentaho.di.trans.steps.*.*Dialog
    >
    >
    > The build will not change, a single jar will be created.
    > I'll probably do this this weekend.
    >
    > Phase 3: New source tree
    > The org.pentaho.di.ui.* packages will be moved to a new source tree
    > kettle/src-ui
    > The build will change, two jars will be created - kettle.jar and
    > kettle-ui.jar
    >
    > Let me know if anyone has concerns about this.
    >
    > James Dixon
    >
    > Chief Geek, Pentaho Corp
    > Citadel International, Suite 340, 5950 Hazeltine National Dr. ,
    > Orlando, FL 32822, USA
    > +1 407 812-OPEN (6736), Fax: 407-517-4575
    > Toll Free: 1-866-496-2703
    >
    >



    --~--~---------~--~----~------------~-------~--~----~
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
    To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
    -~----------~----~----~----~------~----~------~--~---

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.