Hitachi Vantara Pentaho Community Forums
Results 1 to 1 of 1

Thread: [PATCH] FTP: Proxy support, upload and timeout fix

  1. #1
    Join Date
    Jul 2007
    Posts
    8

    Default [PATCH] FTP: Proxy support, upload and timeout fix

    Hello!

    Here's an enhancement for the ftp job entry. It deals with three issues:

    1.) It adds the ability to upload files

    2.) It adds proxy support for upload and download

    3.) Timeout value is now really interpreted as seconds (was ms before).

    The patch is against 2.5.0. It is a bit messy and by no means production ready. (This is why I haven't split it.) I thought I share it so others can test. If the implementation is accepted I will clean it up.

    I'm not sure if it is a good way to implement the upload functionality. I think it would be cleaner to use an abstract base class for the connection and proxy stuff and then create two distinct job etries for upload and download but this would require an "official" entry in the JobEntryInterface.

    I'm not sure about the fix for issue 3. This will change the behaviour of existing jobs. So it might be better to adjust the GUI to show ms correctly

    Regards

    Felix
    Attached Files Attached Files

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.