Advice on moving forward with commit access

[DEinspanjer]

I've got a few patches awaiting tender love in Jira, and now that I've
been granted commit access I was contemplating the best way to handle
them.

Any feedback on things I should do before checking them in and such
would be appreciated.

http://jira.pentaho.org/browse/PDI-785
http://jira.pentaho.org/browse/PDI-784
http://jira.pentaho.org/browse/PDI-768
http://jira.pentaho.org/browse/PDI-707
http://jira.pentaho.org/browse/PDI-702
http://jira.pentaho.org/browse/PDI-682 -- no patch yet, wanted
confirmation it would be useful
http://jira.pentaho.org/browse/PDI-681 -- would need to be redone to
catch up with code drift


Also, I'd like to enhance the user guide a bit, but unfortunately I
would only be able to do so for the English version. Would this be
acceptable or would it cause undesired drift between the different
translations?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "kettle-developers" group.
To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

[Darren Hartford]

I just voted on PDI-784, that one has bugged me for a while but I wasn't
sure if it was just me or not (I don't use dimensions that often, so
chalked up as ignorance and/or my database).

-D

> -----Original Message-----
> From: kettle-developers (AT) googlegroups (DOT) com [mailto:kettle-
> developers (AT) googlegroups (DOT) com] On Behalf Of DEinspanjer
> Sent: Thursday, February 14, 2008 10:58 AM
> To: kettle-developers
> Subject: Advice on moving forward with commit access
>
>
> I've got a few patches awaiting tender love in Jira, and now that I've
> been granted commit access I was contemplating the best way to handle
> them.
>
> Any feedback on things I should do before checking them in and such
> would be appreciated.
>
> http://jira.pentaho.org/browse/PDI-785
> http://jira.pentaho.org/browse/PDI-784
> http://jira.pentaho.org/browse/PDI-768
> http://jira.pentaho.org/browse/PDI-707
> http://jira.pentaho.org/browse/PDI-702
> http://jira.pentaho.org/browse/PDI-682 -- no patch yet, wanted
> confirmation it would be useful
> http://jira.pentaho.org/browse/PDI-681 -- would need to be redone to
> catch up with code drift
>
>
> Also, I'd like to enhance the user guide a bit, but unfortunately I
> would only be able to do so for the English version. Would this be
> acceptable or would it cause undesired drift between the different
> translations?
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "kettle-developers" group.
To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

[Matt Casters]

Hi Daniel,

I'm obviously OK with most bug fixes except for these:

> http://jira.pentaho.org/browse/PDI-768

It's tempting to do this patch, but I'm almost certain we're going to regret
it afterwards. I'm pretty sure that there are differences in behavior
between nearly all Windows versions with respect to the expansion rules.
That being said, we do have an app launcher these days that should be able to
handle the W95/98/ME/2K cases. Seems like a lot of work vs just keeping the
3 bat files in sync with the classpath.

> http://jira.pentaho.org/browse/PDI-682

There are going to be a LOT of changes needed to the codebase and I'm not
certain what the benefit would be. Since change causes instability I would
vote against it. The perceived performance difference is going to be very
close to 0 anyway.

Thanks!

Matt


On Thursday 14 February 2008 16:57:44 DEinspanjer wrote:
> I've got a few patches awaiting tender love in Jira, and now that I've
> been granted commit access I was contemplating the best way to handle
> them.
>
> Any feedback on things I should do before checking them in and such
> would be appreciated.
>
> http://jira.pentaho.org/browse/PDI-785
> http://jira.pentaho.org/browse/PDI-784
> http://jira.pentaho.org/browse/PDI-768
> http://jira.pentaho.org/browse/PDI-707
> http://jira.pentaho.org/browse/PDI-702
> http://jira.pentaho.org/browse/PDI-682 -- no patch yet, wanted
> confirmation it would be useful
> http://jira.pentaho.org/browse/PDI-681 -- would need to be redone to
> catch up with code drift
>
>
> Also, I'd like to enhance the user guide a bit, but unfortunately I
> would only be able to do so for the English version. Would this be
> acceptable or would it cause undesired drift between the different
> translations?
>


--
Matt
____________________________________________
Matt Casters
Chief Data Integration - Kettle founder
Pentaho, Open Source Business Intelligence
http://www.pentaho.org -- mcasters (AT) pentaho (DOT) org
Tel. +32 (0) 486 97 29 37

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "kettle-developers" group.
To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

[DEinspanjer]

It wouldn't work with W9x/ME. If those are supported platforms for
the bat file then that would be a problem.
It would work in NT4 and up unless the user disabled Command
Extensions.

If that is a concern but you aren't ready to drop the .bat support in
favor of the exe, it would probably be best to have the ant script
build the CLASSPATH generation part of the .bat file so that it is
more in lockstep and we won't hit breakages when a new directory is
added.


On Feb 14, 2:05

[Sven Boden]

Seems like a lot of work vs just keeping the 3 bat files in sync with
the classpath ... I would also keep the batch files for now.

For the StringBuilder, I tried some mass changes locally and I got to
a performance increase of 2 to 3%, but some strange things started
happening, if you change one too many it will probably break somewhere
under certain conditions. Maybe it would be better to carefully change
them one by one. It's a lot of work for a little bang.

Regards,
Sven

DEinspanjer wrote:
> It wouldn't work with W9x/ME. If those are supported platforms for
> the bat file then that would be a problem.
> It would work in NT4 and up unless the user disabled Command
> Extensions.
>
> If that is a concern but you aren't ready to drop the .bat support in
> favor of the exe, it would probably be best to have the ant script
> build the CLASSPATH generation part of the .bat file so that it is
> more in lockstep and we won't hit breakages when a new directory is
> added.
>
>
> On Feb 14, 2:05�pm, Matt Casters <mattcast... (AT) gmail (DOT) com> wrote:
> > It's tempting to do this patch, but I'm almost certain we're going to regret
> > it afterwards. �I'm pretty sure that there are differences in behavior
> > between nearly all Windows versions with respect to the expansion rules.
> > That being said, we do have an app launcher these days that should be able to
> > handle the W95/98/ME/2K cases. �Seems like a lot of work vs just keeping the
> > 3 bat files in sync with the classpath.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "kettle-developers" group.
To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
To unsubscribe from this group, send email to kettle-developers-unsubscribe (AT) g...oups (DOT) com
For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
-~----------~----~----~----~------~----~------~--~---