Hitachi Vantara Pentaho Community Forums
Results 1 to 3 of 3

Thread: Blackbox tests and Junit 4

  1. #1
    Phillip Cole Guest

    Default Blackbox tests and Junit 4

    All,

    With reference to http://jira.pentaho.com/browse/PDI-2809 I've been
    looking into BlackboxTests.java. I've converted it to a Junit 4
    parameterised test so that it returns a pass/fail test result for each
    transformation tested rather than a single pass/fail test result for all
    transformations. To do this I've replaced all instances of junit.jar
    (or junit-4.1.jar) with the latest junit-4.7.jar.

    I've removed the checking of the log output - I can't see the sense in
    that, why check if a log file is exactly the same as the previous log
    file. Doesn't it only matter that the output files are identical? I've
    removed one broken transformation that was never going to work - it
    relied on a non-existent FTP site and then checked that the log file was
    output.

    I've got all the remaining unit tests passing on Linux (ubuntu 9.10).
    I've spoken to phyto on IRC and he says hudson can handle JUnit4.

    Is there any objection to me committing this patch?

    Thanks

    Phil


    --~--~---------~--~----~------------~-------~--~----~
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) googlegroups (DOT) com
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
    -~----------~----~----~----~------~----~------~--~---

  2. #2
    Matt Casters Guest

    Default Re: Blackbox tests and Junit 4

    Hi Philip,

    On Sunday 01 November 2009 05:10:33 Phillip Cole wrote:
    > I've
    > removed one broken transformation that was never going to work - it
    > relied on a non-existent FTP site and then checked that the log file was
    > output.


    The idea was to test if the transformation was going to fail.
    I guess that's where the log check came into play.
    I agree that this is not the best way to check failure.
    Perhaps we can add an empty file called "<transformation-name>.fail" to indicate failure.

    > Is there any objection to me committing this patch?


    None at all, bring it on! :-)

    Thanks!
    Matt

    Matt Casters <mcasters (AT) pentaho (DOT) org>
    Chief Data Integration
    Fonteinstraat 70, 9400 OKEGEM - Belgium - Cell : +32 486 97 29 37
    Pentaho : The Commercial Open Source Alternative for Business Intelligence

    --~--~---------~--~----~------------~-------~--~----~
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) googlegroups (DOT) com
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
    -~----------~----~----~----~------~----~------~--~---

  3. #3
    Phil Cole Guest

    Default Re: Blackbox tests and Junit 4

    Hi Matt,

    http://jira.pentaho.com/browse/PDI-2809 has now been comitted. The blackbox
    tests now pass on Windows and Linux.

    Would it be possible to add "tests-blackbox" as an additional ant parameter
    for the hudson build?

    Thanks

    --
    Phil

    --~--~---------~--~----~------------~-------~--~----~
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) googlegroups (DOT) com
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en
    -~----------~----~----~----~------~----~------~--~---

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.