Hitachi Vantara Pentaho Community Forums
Results 1 to 9 of 9

Thread: four bugs with Regex step

  1. #1

    Smile four bugs with Regex step

    Please advise on what to do with these. Should they be one jira ticket or four?

    I plan to try to fix these myself. Should I submit the fix as one patch or four?

    --Buck

    1. regex tester capture box doesn't size properly

      Original size is one line, which is rarely adequate, and doesn't resize until the window is resized horizontally (!?). Even then, it sizes to the data rather than the window, causing the bottom of the box to sometimes be outside the window border with no scrollbar available. In the case of many matches (~15) the last entry is complete unviewable.

      Fix would be to make the box sized relative to the window, rather than the data, and ensure it has a scrollbar when necessary.
    2. regex tester doesn't handle null captures correctly

      If a regex-capture does not match (eg ".*(a)?" vs "abc") then the returning value is null, and the tester gives the error "Argument cannot be null".

      This is a very common regex pattern and should not be an error condition. Since kettle treats null values as empty string elsewhere, I believe (please confirm?) it makes sense to display an empty string as the match, rather than giving an error.
    3. doesn't populate new fields properly (overwrites from column 1)

      I'm seeing behavior when two regex steps are connected, the second regex step writes into the wrong fields, leaving the proper match columns blank. Example available on request.
    4. tester doesn't respect multiline option

      With long, complicated regular expressions, the multiline option (Content -> "permit whitespace and comments") is invaluable. This works during transformation, but the regex tester does not respect the setting causing incorrect results.

    Last edited by bukzor; 02-04-2011 at 02:38 PM. Reason: formatting

  2. #2

    Default

    Four bugs should be fine :-)

    Thanks
    Samatar

  3. #3
    Join Date
    Apr 2008
    Posts
    146

    Default

    Please post links to your JIRA's once they are created. I would be interested in following and voting for them.

  4. #4

    Default

    Does anyone have handy guidelines or previous art for patch submission?
    I'm working on creating the four patches now.

    I'll probably post the one big patch here as well.

  5. #5

  6. #6

    Default

    Samatar:

    The patch I submitted here is broke, sorry.
    http://jira.pentaho.com/browse/PDI-5370

    Please revert.

    Submitting a new one asap.

    --Buck

  7. #7

    Default

    Sumitted complete patch:

    http://jira.pentaho.com/browse/PDI-5370

  8. #8

    Default

    Patches for issues 1/2/4 attached.

    To apply:

    Code:
    patch -p0 < patches/regexhelper.nullcapture.patch
    Attached Files Attached Files

  9. #9

    Default

    One last bug remaining. I have some questions though.

    Please comment:
    http://jira.pentaho.com/browse/PDI-5369

Tags for this Thread

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.