Hitachi Vantara Pentaho Community Forums
Results 1 to 4 of 4

Thread: [Mondrian] RowsetDefinition.java - possible minor bug

  1. #1
    Michele Rossi Guest

    Default [Mondrian] RowsetDefinition.java - possible minor bug

    Hi,
    if you look at line 4527 of RowsetDefinition.java
    (mondrian.xmla.RowsetDefinition) you will see


    row.set(DefaultMember.name, hierarchy.getDefaultMember());

    which I think should be

    row.set(DefaultMember.name, hierarchy.getDefaultMember().getUniqueName());

    The current implementation is calling toString() on the default member so it
    only works if toString() is the same as getUniqueName().

    thanks,
    Michele

    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

  2. #2
    Julian Hyde Guest

    Default RE: [Mondrian] RowsetDefinition.java - possible minor bug

    Generally Member.toString() is equivalent to getUniqueName(). If there are
    any subclasses where this is not the case, let me know. Otherwise I don't
    consider this a bug.

    Julian


    _____

    From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org] On
    Behalf Of Michele Rossi
    Sent: Friday, May 20, 2011 10:18 AM
    To: Mondrian developer mailing list
    Subject: [Mondrian] RowsetDefinition.java - possible minor bug


    Hi,
    if you look at line 4527 of RowsetDefinition.java
    (mondrian.xmla.RowsetDefinition) you will see


    row.set(DefaultMember.name, hierarchy.getDefaultMember());

    which I think should be

    row.set(DefaultMember.name, hierarchy.getDefaultMember().getUniqueName());

    The current implementation is calling toString() on the default member so it
    only works if toString() is the same as getUniqueName().

    thanks,
    Michele


    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

  3. #3
    Michele Rossi Guest

    Default Re: [Mondrian] RowsetDefinition.java - possible minor bug

    hi,
    my implementation of Member didn't have toString() returning getUniqueName()..

    In general I think such constraint is hard to enforce.

    And this affects the xmla support which relies solely on olap4j.

    So I think many similar situations will start to be flagged as people plug their own olap4j implementations into the xmla servlet.

    Thanks,
    Michele

    Sent from my iPhone

    On 21 May 2011, at 01:47, Julian Hyde <jhyde (AT) pentaho (DOT) com> wrote:

    > Generally Member.toString() is equivalent to getUniqueName(). If there are any subclasses where this is not the case, let me know. Otherwise I don't consider this a bug.
    >
    > Julian
    >
    > From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org] On Behalf Of Michele Rossi
    > Sent: Friday, May 20, 2011 10:18 AM
    > To: Mondrian developer mailing list
    > Subject: [Mondrian] RowsetDefinition.java - possible minor bug
    >
    > Hi,
    > if you look at line 4527 of RowsetDefinition.java (mondrian.xmla.RowsetDefinition) you will see
    >
    >
    > row.set(DefaultMember.name, hierarchy.getDefaultMember());
    >
    > which I think should be
    >
    > row.set(DefaultMember.name, hierarchy.getDefaultMember().getUniqueName());
    >
    > The current implementation is calling toString() on the default member so it only works if toString() is the same as getUniqueName().
    >
    > thanks,
    > Michele
    > _______________________________________________
    > Mondrian mailing list
    > Mondrian (AT) pentaho (DOT) org
    > http://lists.pentaho.org/mailman/listinfo/mondrian


    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

  4. #4
    Julian Hyde Guest

    Default RE: [Mondrian] RowsetDefinition.java - possible minor bug

    Fair enough. I had forgotten that the XMLA server now needs to run on
    3rd-party olap4j drivers. It is unreasonable to expect them to make
    Member.toString() equivalent to getUniqueName().

    Fixed in change 14308. I also checked for other violations; there are none.

    Julian

    PS I am (at last) reviewing/reworking your patch for authentication. I have
    quite a few comments already. It will take another couple of days.


    _____

    From: Michele Rossi [mailto:michele.rossi (AT) gmail (DOT) com]
    Sent: Saturday, May 21, 2011 2:09 AM
    To: jhyde (AT) pentaho (DOT) com; Mondrian developer mailing list
    Cc: Mondrian developer mailing list
    Subject: Re: [Mondrian] RowsetDefinition.java - possible minor bug


    hi,
    my implementation of Member didn't have toString() returning
    getUniqueName().

    In general I think such constraint is hard to enforce.

    And this affects the xmla support which relies solely on olap4j.

    So I think many similar situations will start to be flagged as people plug
    their own olap4j implementations into the xmla servlet.

    Thanks,
    Michele

    Sent from my iPhone

    On 21 May 2011, at 01:47, Julian Hyde <jhyde (AT) pentaho (DOT) com> wrote:



    Generally Member.toString() is equivalent to getUniqueName(). If there are
    any subclasses where this is not the case, let me know. Otherwise I don't
    consider this a bug.

    Julian


    _____

    From: mondrian-bounces (AT) pentaho (DOT) org [mailto:mondrian-bounces (AT) pentaho (DOT) org] On
    Behalf Of Michele Rossi
    Sent: Friday, May 20, 2011 10:18 AM
    To: Mondrian developer mailing list
    Subject: [Mondrian] RowsetDefinition.java - possible minor bug


    Hi,
    if you look at line 4527 of RowsetDefinition.java
    (mondrian.xmla.RowsetDefinition) you will see


    row.set(DefaultMember.name, hierarchy.getDefaultMember());

    which I think should be

    row.set(DefaultMember.name, hierarchy.getDefaultMember().getUniqueName());

    The current implementation is calling toString() on the default member so it
    only works if toString() is the same as getUniqueName().

    thanks,
    Michele

    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian



    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.