Hitachi Vantara Pentaho Community Forums
Results 1 to 2 of 2

Thread: Re: [Mondrian] SF.net SVN: olap4j:[468] trunk

  1. #1
    Luc Boudreau Guest

    Default Re: [Mondrian] SF.net SVN: olap4j:[468] trunk

    Paul,

    I believe your fix to the Query Model is causing failures in Mondrian's
    regression test suite. Would you mind giving it a look?

    Thanks

    Luc

    ref:
    http://ci.pentaho.com/view/Analysis/...ld/testReport/


    On Tue, Aug 2, 2011 at 12:33 PM, <pstoellberger (AT) users (DOT) sourceforge.net>wrote:

    > Revision: 468
    > http://olap4j.svn.sourceforge.net/ol...v=468&view=rev
    > Author: pstoellberger
    > Date: 2011-08-02 16:33:53 +0000 (Tue, 02 Aug 2011)
    >
    > Log Message:
    > -----------
    > Bug CalculatedMembers in virtual cube dont show up fixed -
    > http://sourceforge.net/tracker/?func...53&atid=848534.
    > enabled test case from now on
    >
    > Modified Paths:
    > --------------
    > trunk/src/org/olap4j/impl/Bug.java
    > trunk/testsrc/org/olap4j/ConnectionTest.java
    >
    > Modified: trunk/src/org/olap4j/impl/Bug.java
    > ===================================================================
    > --- trunk/src/org/olap4j/impl/Bug.java 2011-08-02 16:21:51 UTC (rev 467)
    > +++ trunk/src/org/olap4j/impl/Bug.java 2011-08-02 16:33:53 UTC (rev 468)
    > @@ -61,13 +61,6 @@
    > */
    > public static final boolean BugOlap4j3126853Fixed = false;
    >
    > - /**
    > - * Whether
    > - * <a href="
    > http://sourceforge.net/tracker/?func=detail&aid=3312701&group_id=168953&atid=848534">bug
    > 3312701,
    > - * "ConnectionTest.testVirtualCubeCmBug hangs"</a>
    > - * is fixed.
    > - */
    > - public static final boolean BugOlap4j3312701Fixed = false;
    > }
    >
    > // End Bug.java
    >
    > Modified: trunk/testsrc/org/olap4j/ConnectionTest.java
    > ===================================================================
    > --- trunk/testsrc/org/olap4j/ConnectionTest.java 2011-08-02 16:21:51
    > UTC (rev 467)
    > +++ trunk/testsrc/org/olap4j/ConnectionTest.java 2011-08-02 16:33:53
    > UTC (rev 468)
    > @@ -2076,9 +2076,6 @@
    > * Calculated Members"
    > */
    > public void testVirtualCubeCmBug() throws Exception {
    > - if (!Bug.BugOlap4j3312701Fixed) {
    > - return;
    > - }
    > Class.forName(tester.getDriverClassName());
    > connection = tester.createConnection();
    > OlapConnection olapConnection =
    > @@ -2104,6 +2101,7 @@
    > "Unit Sales",
    > "Profit",
    > "Profit Growth",
    > + "Profit Per Unit Shipped",
    > "Store Invoice",
    > "Supply Time",
    > "Units Ordered",
    >
    >
    > This was sent by the SourceForge.net collaborative development platform,
    > the world's largest Open Source development site.
    >


    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

  2. #2
    Paul Stoellberger Guest

    Default Re: [Mondrian] SF.net SVN: olap4j:[468] trunk

    This is weird because those tests actually work (and only depend on olap4j).
    The changes were actually made in 469: http://olap4j.svn.sourceforge.net/vi...n&revision=469

    The failing test seems to use a new version (after 469) for the test code but an old version (pre 469) for the actual query model code. There is now way the test case can output this failure post 469.

    I had some issues with retrieving the latest olap4j-1.0.0-SNAPSHOT and deleted it in the maven repository manually to force a new retrieval from the pentaho repository.

    olap4j passed this test without a problem in the latest build: http://ci.pentaho.com/job/olap4j/605...hyConsistency/

    So from my point of view there is nothing wrong with my code, but some problem with the olap4j.jar being used for the regression tests.

    -Paul


    On Aug 3, 2011, at 3:05 PM, Luc Boudreau wrote:

    > Paul,
    >
    > I believe your fix to the Query Model is causing failures in Mondrian's regression test suite. Would you mind giving it a look?
    >
    > Thanks
    >
    > Luc
    >
    > ref: http://ci.pentaho.com/view/Analysis/...ld/testReport/
    >
    >
    > On Tue, Aug 2, 2011 at 12:33 PM, <pstoellberger (AT) users (DOT) sourceforge.net> wrote:
    > Revision: 468
    > http://olap4j.svn.sourceforge.net/ol...v=468&view=rev
    > Author: pstoellberger
    > Date: 2011-08-02 16:33:53 +0000 (Tue, 02 Aug 2011)
    >
    > Log Message:
    > -----------
    > Bug CalculatedMembers in virtual cube dont show up fixed - http://sourceforge.net/tracker/?func...53&atid=848534. enabled test case from now on
    >
    > Modified Paths:
    > --------------
    > trunk/src/org/olap4j/impl/Bug.java
    > trunk/testsrc/org/olap4j/ConnectionTest.java
    >
    > Modified: trunk/src/org/olap4j/impl/Bug.java
    > ===================================================================
    > --- trunk/src/org/olap4j/impl/Bug.java 2011-08-02 16:21:51 UTC (rev 467)
    > +++ trunk/src/org/olap4j/impl/Bug.java 2011-08-02 16:33:53 UTC (rev 468)
    > @@ -61,13 +61,6 @@
    > */
    > public static final boolean BugOlap4j3126853Fixed = false;
    >
    > - /**
    > - * Whether
    > - * <a href="http://sourceforge.net/tracker/?func=detail&aid=3312701&group_id=168953&atid=848534">bug 3312701,
    > - * "ConnectionTest.testVirtualCubeCmBug hangs"</a>
    > - * is fixed.
    > - */
    > - public static final boolean BugOlap4j3312701Fixed = false;
    > }
    >
    > // End Bug.java
    >
    > Modified: trunk/testsrc/org/olap4j/ConnectionTest.java
    > ===================================================================
    > --- trunk/testsrc/org/olap4j/ConnectionTest.java 2011-08-02 16:21:51 UTC (rev 467)
    > +++ trunk/testsrc/org/olap4j/ConnectionTest.java 2011-08-02 16:33:53 UTC (rev 468)
    > @@ -2076,9 +2076,6 @@
    > * Calculated Members"
    > */
    > public void testVirtualCubeCmBug() throws Exception {
    > - if (!Bug.BugOlap4j3312701Fixed) {
    > - return;
    > - }
    > Class.forName(tester.getDriverClassName());
    > connection = tester.createConnection();
    > OlapConnection olapConnection =
    > @@ -2104,6 +2101,7 @@
    > "Unit Sales",
    > "Profit",
    > "Profit Growth",
    > + "Profit Per Unit Shipped",
    > "Store Invoice",
    > "Supply Time",
    > "Units Ordered",
    >
    >
    > This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
    >



    _______________________________________________
    Mondrian mailing list
    Mondrian (AT) pentaho (DOT) org
    http://lists.pentaho.org/mailman/listinfo/mondrian

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2019 Hitachi Vantara Corporation. All Rights Reserved.