Hitachi Vantara Pentaho Community Forums
Results 1 to 4 of 4

Thread: [PATCH] Refactor InsertUpdate.processRow (first) - REVIEW NEEDED

  1. #1
    Max Hofer Guest

    Default [PATCH] Refactor InsertUpdate.processRow (first) - REVIEW NEEDED

    Split functionality in simpler, smaller methods. Move those methods to
    InsertUpdateMeta (code smell: InsertUpdate called a lot of methods loacted in
    InsertUpdateMeta class). The InsertUpdateMeta class is used to fill
    InsertUpdateData.

    NOTE: review needed - some logging statements were disabled since we have no
    access to the logging object in InsertUpdateMeta. Is there a way to log from the
    InsertUpdateMeta class?


    --
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com.
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) g...oups (DOT) com.
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en.

  2. #2
    Max Guest

    Default Re: [PATCH] Refactor InsertUpdate.processRow (first) - REVIEWNEEDED

    I'm currently working on PDI-6522 (or at least I read into the existing
    code).

    The patch above is my first try to refactor the existing code. Since I'm new
    I have
    some general questions.

    Is such code cleaning wanted?

    Who is going to review the patches? Is there a kind of mentor for project
    newbies to whom we
    can address general questions?

    Now some specific questions to the patch:
    * is there a kind of documentation for the threading model used in PDI? It
    is kind of hard to write
    multi-threading code if the big-picture for it is missing.
    * Logging: the patch disabled some logging information because the
    InsertUpdateMeta class
    has no access to the logging object of InsertUpdate. Can the "MetaData"
    class also log?

    kinds regards,
    Max

    --
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To view this discussion on the web visit https://groups.google.com/d/msg/kett...-/WNCwZIXmQlIJ.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com.
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) g...oups (DOT) com.
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en.

  3. #3
    marc.marschner@fredhopper.com Guest

    Default Out of Office

    Thank you for your email. Unfortunately, I will be out of the office until 31/08/2011 and have limited access to email and telephone.

    Please use one of the following contact options to get assistance:

    - Contact Fredhopper Support at +31 20 530 111

    - Visit https://www.fredhopper.com/learningcenter

    You can always call me on my mobile phone, although I might not be able to answer it directly.

    Kind regards,

    Marc Marschner

    --
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com.
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) g...oups (DOT) com.
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en.

  4. #4
    Will Gorman Guest

    Default Re: [PATCH] Refactor InsertUpdate.processRow (first) - REVIEW NEEDED

    Hi Max,

    Thanks for this and the other patches as well! Please create JIRA
    cases for each patch that you'd like to see incorporated into the
    product, we'll make sure to review the code changes.

    Will

    On Wed, Aug 10, 2011 at 3:52 PM, Max <mh182 (AT) gmx (DOT) net> wrote:
    > I'm currently working on PDI-6522 (or at least I read into the existing
    > code).
    >
    > The patch above is my first try to refactor the existing code. Since I'm new
    > I have
    > some general questions.
    >
    > Is such code cleaning wanted?
    >
    > Who is going to review the patches? Is there a kind of mentor for project
    > newbies to whom we
    > can address general questions?
    >
    > Now some specific questions to the patch:
    > * is there a kind of documentation for the threading model used in PDI? It
    > is kind of hard to write
    > multi-threading code if the big-picture for it is missing.
    > * Logging: the patch disabled some logging information because the
    > InsertUpdateMeta class
    > has no access to the logging object of InsertUpdate. Can the "MetaData"
    > class also log?
    >
    > kinds regards,
    > Max
    >
    > --
    > You received this message because you are subscribed to the Google Groups
    > "kettle-developers" group.
    > To view this discussion on the web visit
    > https://groups.google.com/d/msg/kett...-/WNCwZIXmQlIJ.
    > To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com.
    > To unsubscribe from this group, send email to
    > kettle-developers+unsubscribe (AT) g...oups (DOT) com.
    > For more options, visit this group at
    > http://groups.google.com/group/kettle-developers?hl=en.
    >


    --
    You received this message because you are subscribed to the Google Groups "kettle-developers" group.
    To post to this group, send email to kettle-developers (AT) googlegroups (DOT) com.
    To unsubscribe from this group, send email to kettle-developers+unsubscribe (AT) g...oups (DOT) com.
    For more options, visit this group at http://groups.google.com/group/kettle-developers?hl=en.

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
Privacy Policy | Legal Notices | Safe Harbor Privacy Policy

Copyright © 2005 - 2017 Pentaho Corporation. All Rights Reserved.